Revert to old syntax with .then()

software-mansion-labs · Mar 21, 2024 · 8168992 · 8168992
1 parent 84b1c5c
commit 8168992
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts
@@ -1732,14 +1732,12 @@ function navigateToConciergeChat(shouldDismissModal = false, checkIfCurrentPageA
     if (!conciergeChatReportID) {
         // In order to avoid creating concierge repeatedly,
         // we need to ensure that the server data has been successfully pulled
-        Welcome.onServerDataReady({
-            onReady: () => {
-                // If we don't have a chat with Concierge then create it
-                if (!checkIfCurrentPageActive()) {
-                    return;
-                }
-                navigateToAndOpenReport([CONST.EMAIL.CONCIERGE], shouldDismissModal);
-            },
+        Welcome.onServerDataReady().then(() => {
+            // If we don't have a chat with Concierge then create it
+            if (!checkIfCurrentPageActive()) {
+                return;
+            }
+            navigateToAndOpenReport([CONST.EMAIL.CONCIERGE], shouldDismissModal);
         });
     } else if (shouldDismissModal) {
         Navigation.dismissModal(conciergeChatReportID);

diff --git a/src/libs/actions/Welcome.ts b/src/libs/actions/Welcome.ts
@@ -36,10 +36,8 @@ const isOnboardingFlowStatusKnownPromise = new Promise<void>((resolve) => {
     resolveOnboardingFlowStatus = resolve;
 });
 
-function onServerDataReady({onReady}: ServerDataReadyProps): Promise<void> {
-    return isServerDataReadyPromise.then(() => {
-        onReady();
-    });
+function onServerDataReady(): Promise<void> {
+    return isServerDataReadyPromise;
 }
 
 /**