Rewritted Promise race to regular for loop

software-mansion-labs · Sep 26, 2023 · dbdcafb · dbdcafb
1 parent 02c65f5
commit dbdcafb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.github/actions/javascript/authorChecklist/index.js b/.github/actions/javascript/authorChecklist/index.js
@@ -272,7 +272,13 @@ async function detectReactComponentInFile(filename) {
 ;
 async function detectFunction(changedFiles) {
     const filteredFiles = _.filter((changedFiles), ({ filename }) => filename.endsWith('.js') || filename.endsWith('.jsx') || filename.endsWith('.ts') || filename.endsWith('.tsx'));
-    return Promise.race(_.map(filteredFiles, ({ filename }) => detectReactComponentInFile(filename)));
+    for (const file of filteredFiles) {
+        const result = await detectReactComponentInFile(file.filename);
+        if (result) {
+            return true; // If the check is true, exit directly
+        }
+    }
+    return false;
 };
 
 module.exports = {

diff --git a/.github/actions/javascript/authorChecklist/newComponentCategory.js b/.github/actions/javascript/authorChecklist/newComponentCategory.js
@@ -71,7 +71,13 @@ async function detectReactComponentInFile(filename) {
 ;
 async function detectFunction(changedFiles) {
     const filteredFiles = _.filter((changedFiles), ({ filename }) => filename.endsWith('.js') || filename.endsWith('.jsx') || filename.endsWith('.ts') || filename.endsWith('.tsx'));
-    return Promise.race(_.map(filteredFiles, ({ filename }) => detectReactComponentInFile(filename)));
+    for (const file of filteredFiles) {
+        const result = await detectReactComponentInFile(file.filename);
+        if (result) {
+            return true; // If the check is true, exit directly
+        }
+    }
+    return false;
 };
 
 module.exports = {