Refactor workspace switcher and PolicyMembersUtils

software-mansion-labs · Feb 1, 2024 · efea383 · efea383
1 parent 45ec867
commit efea383
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.ts b/src/libs/Notification/PushNotification/subscribeToReportCommentPushNotifications.ts
@@ -59,7 +59,7 @@ export default function subscribeToReportCommentPushNotifications() {
 
                         Log.info('[PushNotification] onSelected() - Navigation is ready. Navigating...', false, {reportID, reportActionID});
                         if (!reportBelongsToWorkspace) {
-                            Navigation.navigateWithSwitchPolicyID({policyID: undefined, route: ROUTES.HOME});
+                            Navigation.navigateWithSwitchPolicyID({route: ROUTES.HOME});
                         }
                         Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(String(reportID)));
                     } catch (error) {

diff --git a/src/libs/PolicyMembersUtils.ts b/src/libs/PolicyMembersUtils.ts
@@ -3,6 +3,7 @@ import Onyx from 'react-native-onyx';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {PolicyMembers} from '@src/types/onyx';
 import {getCurrentUserAccountID} from './actions/Report';
+import {getPolicyMembersByIdWithoutCurrentUser} from './PolicyUtils';
 
 let policyMembers: OnyxCollection<PolicyMembers>;
 Onyx.connect({
@@ -17,11 +18,8 @@ function getPolicyMemberAccountIDs(policyID?: string) {
     }
 
     const currentUserAccountID = getCurrentUserAccountID();
-    return policyMembers
-        ? Object.keys(policyMembers[`${ONYXKEYS.COLLECTION.POLICY_MEMBERS}${policyID}`] ?? {})
-              .map((policyMemberAccountID) => Number(policyMemberAccountID))
-              .filter((policyMemberAccountID) => policyMemberAccountID !== currentUserAccountID)
-        : [];
+
+    return getPolicyMembersByIdWithoutCurrentUser(policyMembers, policyID, currentUserAccountID);
 }
 
 export default getPolicyMemberAccountIDs;
diff --git a/src/pages/WorkspaceSwitcherPage.js b/src/pages/WorkspaceSwitcherPage.js
@@ -192,7 +192,7 @@ function WorkspaceSwitcherPage({policies}) {
                 </View>
                 <View>
                     <OptionRow
-                        option={{...option, brickRoadIndicator: !activeWorkspaceID ? undefined : option.brickRoadIndicator}}
+                        option={option}
                         onSelectRow={selectPolicy}
                         showTitleTooltip={false}
                         shouldShowSubscript={false}