Skip to content

Commit

Permalink
Merge pull request Expensify#29880 from Expensify/tgolen-todos
Browse files Browse the repository at this point in the history
Remove and fix some TODOs that exist in the code
  • Loading branch information
nkuoch authored Oct 20, 2023
2 parents de74f35 + 187cbef commit f01dce4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/libs/Navigation/OnyxTabNavigator.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ import Tab from '../actions/Tab';
import ONYXKEYS from '../../ONYXKEYS';

const propTypes = {
/* ID of the tab component to be saved in onyx */
/** ID of the tab component to be saved in onyx */
id: PropTypes.string.isRequired,

/* Name of the selected tab */
/** Name of the selected tab */
selectedTab: PropTypes.string,

/* Children nodes */
/** Children nodes */
children: PropTypes.node.isRequired,
};

Expand Down
2 changes: 1 addition & 1 deletion src/libs/actions/BankAccounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ function connectBankAccountWithPlaid(bankAccountID: number, selectedPlaidBankAcc
/**
* Adds a bank account via Plaid
*
* @TODO offline pattern for this command will have to be added later once the pattern B design doc is complete
* TODO: offline pattern for this command will have to be added later once the pattern B design doc is complete
*/
function addPersonalBankAccount(account: PlaidBankAccount) {
const commandName = 'AddPersonalBankAccount';
Expand Down
2 changes: 0 additions & 2 deletions src/pages/DetailsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ function DetailsPage(props) {
let details = _.find(props.personalDetails, (detail) => detail.login === login.toLowerCase());

if (!details) {
// TODO: these personal details aren't in my local test account but are in
// my staging account, i wonder why!
if (login === CONST.EMAIL.CONCIERGE) {
details = {
accountID: CONST.ACCOUNT_ID.CONCIERGE,
Expand Down

0 comments on commit f01dce4

Please sign in to comment.