Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wave9] Require name + surname #69

Merged
merged 25 commits into from
Feb 28, 2024
Merged

[Wave9] Require name + surname #69

merged 25 commits into from
Feb 28, 2024

Conversation

MaciejSWM
Copy link

@MaciejSWM MaciejSWM commented Feb 22, 2024 •
edited
Loading

https://linear.app/expensify-swm/issue/EXP-276/[wave-9]-new-onboarding-flow-requiring-name-surname-purpose

What is not done:

  1. Custom error message when user clicks on the modal overlay area - difficult to make it work nicely with validations and without loosing the entered input. Postponing - created a separate ticket in linear (https://linear.app/expensify-swm/issue/EXP-326/[wave-9]-require-name-surname-custom-error-message-on-modal-overflow).
  2. Tests failing - will be handled in a separate ticket (https://linear.app/expensify-swm/issue/EXP-304/[wave-9]-new-onboarding-flow-automated-tests)

image

@MaciejSWM MaciejSWM marked this pull request as draft February 22, 2024 12:01
@MaciejSWM MaciejSWM changed the title Wave9/require name surname [Wave9] Require name + surname Feb 27, 2024
@MaciejSWM MaciejSWM marked this pull request as ready for review February 27, 2024 12:45
blazejkustra
blazejkustra requested changes Feb 27, 2024
View reviewed changes
src/components/HeaderWithBackButton/index.tsx Show resolved Hide resolved
src/libs/ValidationUtils.ts Show resolved Hide resolved
src/styles/variables.ts Outdated Show resolved Hide resolved
src/pages/OnboardingPersonalDetails.tsx Outdated Show resolved Hide resolved
@MaciejSWM MaciejSWM merged commit b20682f into wave9/onboarding-flow Feb 28, 2024
7 of 13 checks passed
@MaciejSWM MaciejSWM deleted the wave9/require-name-surname branch February 28, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazejkustra blazejkustra blazejkustra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaciejSWM @blazejkustra