Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cairo highlighting support straight to mdBook repository #1525

Open
wawel37 opened this issue Aug 19, 2024 · 4 comments
Open

Add Cairo highlighting support straight to mdBook repository #1525

wawel37 opened this issue Aug 19, 2024 · 4 comments
Milestone

Comments

@wawel37
Copy link
Contributor

wawel37 commented Aug 19, 2024

No description provided.

@wawel37 wawel37 added this to Scarb Aug 19, 2024
@wawel37 wawel37 self-assigned this Aug 19, 2024
@wawel37 wawel37 converted this from a draft issue Aug 19, 2024
@maciektr
Copy link
Contributor

maciektr commented Sep 3, 2024

After this is done, replace rust with cairo here:

writeln!(&mut markdown, "```rust\n{sig}\n```\n").unwrap();

@wawel37
Copy link
Contributor Author

wawel37 commented Nov 6, 2024

PR created in mdBook repository. rust-lang/mdBook#2468

@wawel37
Copy link
Contributor Author

wawel37 commented Nov 7, 2024

Update: mdBook requires us to make highlight.js support cairo directly. Made PR with changes to highlight.js directly:
highlightjs/highlight.js#4162

@wawel37
Copy link
Contributor Author

wawel37 commented Nov 26, 2024

Unfortunately people from mdBook rejected any kind of way of adding support for custom language highlighting as for now. When the mdBook update the highlight.js, we can retry with a Cairo support inside highlighting theme.

@wawel37 wawel37 removed their assignment Nov 26, 2024
@wawel37 wawel37 moved this from In Progress to Backlog in Scarb Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants