intro-to-solana-mobile.md - refactor: optimize counter increment logic and notification handling #355
Conversation
- Refactored showToastOrAlert to showNotification for better clarity. - Improved async/await usage with consistent error handling using try/catch. - Added detailed logging for missing program or counterAddress. - Cleaned up and grouped logic for better readability and maintainability. - Ensured balance checks and airdrop requests are well-handled during transactions.
mikemaccana
changed the title
|
Thanks! Needs a little work but we can get this in once done. |
mikemaccana
added
superteam-lesson-updates
and removed
good first issue
Thank you Mike! Looking forward to that. |
| } else { | ||
| Alert.alert(message); | ||
| } | ||
| const showNotification = (message: string) => { |
There was a problem hiding this comment.
This does not show notifications.
There was a problem hiding this comment.
this does show notification. can you please elaborate on this review
There was a problem hiding this comment.
Does it create one of these?
There was a problem hiding this comment.
It creates these instead:
There was a problem hiding this comment.
That's not a 'notification' then. The word notification has a very specific meaning on mobile. Please change the function name.
There was a problem hiding this comment.
changed to showMessage()
changed to showMessage✅ |
|
This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days. |
Problem
Summary of Changes
Refactored showToastOrAlert to showNotification for better clarity.
Improved async/await usage with consistent error handling using try/catch.
Added detailed logging for missing program or counterAddress.
Cleaned up and grouped logic for better readability and maintainability.
Ensured balance checks and airdrop requests are well-handled during transactions.