-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nft recipes from cookbook #383
Conversation
heyAyushh
commented
Aug 28, 2024
- Added nft docs for metaplex token metadata program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes, but not many.
import fs from "node:fs"; | ||
import Arweave from "arweave"; | ||
|
||
(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd skip the wrapper function, then tell people to use npx esrun upload-to-arweave.ts
. https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#jsts
Same with the other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be refactored when code-import happens so I can ensure all the files are changed and getting executed. I hope this makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix suggested, but approved.