Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nft recipes from cookbook #383

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

heyAyushh
Copy link
Contributor

  • Added nft docs for metaplex token metadata program

@heyAyushh heyAyushh requested a review from nickfrosty as a code owner August 28, 2024 22:29
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, but not many.

import fs from "node:fs";
import Arweave from "arweave";

(async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd skip the wrapper function, then tell people to use npx esrun upload-to-arweave.ts. https://github.com/solana-foundation/developer-content/blob/main/CONTRIBUTING.md#jsts

Same with the other files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be refactored when code-import happens so I can ensure all the files are changed and getting executed. I hope this makes sense

content/cookbook/tokens/create-nft.md Outdated Show resolved Hide resolved
content/cookbook/tokens/create-nft.md Outdated Show resolved Hide resolved
content/cookbook/tokens/create-nft.md Outdated Show resolved Hide resolved
content/cookbook/tokens/create-nft.md Show resolved Hide resolved
content/cookbook/tokens/get-nft-owner.md Outdated Show resolved Hide resolved
content/cookbook/tokens/create-nft.md Show resolved Hide resolved
content/cookbook/tokens/non-fungible-tokens.md Outdated Show resolved Hide resolved
content/cookbook/tokens/create-nft.md Outdated Show resolved Hide resolved
content/cookbook/tokens/get-nft-owner.md Show resolved Hide resolved
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix suggested, but approved.

content/cookbook/tokens/create-nft.md Show resolved Hide resolved
@mikemaccana mikemaccana merged commit f974d12 into solana-foundation:main Sep 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants