This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Feature Gate: Removing unwanted rounding in fee calculation #34982
Labels
feature-gate
Pull Request adds or modifies a runtime feature gate
Comments
tao-stones
added
the
feature-gate
This was referenced Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
SIMD
none
Description
A carry-over: transaction fee is converted to
f64, thenround()then convert back tou64. This is unnecessary, and rounding largef64isn't accurate sincef64has precision of 53 binary digits (eg 2^53).The conversion and rounding should be removed, but since it'd result different transaction fee is value is large enough, this change needs feature gate.
Feature ID
BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF
Activation Method
Single Core Contributor
Deployment Considerations
none
Minimum Beta Version
2.0.0
Minimum Stable Version
No response
Testnet Activation Epoch
715
Devnet Activation Epoch
802
Mainnet-Beta Activation Epoch
No response
The text was updated successfully, but these errors were encountered: