Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all sysvar pubkeys from instructions interface #53

Open
2501babe opened this issue Feb 11, 2025 · 0 comments
Open

remove all sysvar pubkeys from instructions interface #53

2501babe opened this issue Feb 11, 2025 · 0 comments
Labels
program related to the core bpf program itself

Comments

@2501babe
Copy link
Member

2501babe commented Feb 11, 2025

because of syscalls, we do not need to pass in any sysvar accounts. we can also get rid of stake config entirely. to preserve the interface for past transactions, we can skip the relevant accounts in a wrapper on next_account_info()

this should (in the case of clock and rent) and absolutely will greatly (in the case of stake history) reduce CU usage because these accounts do not need to be parsed into AccountInfos. it will also make transactions that use stake account instructions typically 32-128 bytes smaller

this was not done for the initial version on purpose because above all else except correctness, we prioritized following the native stake program as closely as possible, to de-risk the native/bpf switchover. but this is probably the first pr i will land after launch

@2501babe 2501babe changed the title program: remove all sysvar pubkeys from instructions interface remove all sysvar pubkeys from instructions interface Feb 11, 2025
@2501babe 2501babe added the program related to the core bpf program itself label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
program related to the core bpf program itself
Projects
None yet
Development

No branches or pull requests

1 participant