NH-55892 fix the gem name #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
previously approved these changes
Dec 12, 2023
cheempz
requested changes
Dec 30, 2023
There was a problem hiding this comment.
@xuan-cao-swi can you also fix the problem that this workflow will finish successfully even though a step in the shell script failed? The last line echo "Finished" is one pitfall (its success status becomes exit status of script and the workflow) but please also check for others.
And a corresponding PR for https://github.com/solarwinds/opentelemetry-ruby-contrib/blob/main/.github/workflows/script/sw_build_and_push_gem.sh too please :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.