Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcode config duplicates #22

Open
DKudleichuk opened this issue Feb 21, 2019 · 0 comments
Open

Shortcode config duplicates #22

DKudleichuk opened this issue Feb 21, 2019 · 0 comments
Labels
invalid This doesn't seem right question Further information is requested

Comments

@DKudleichuk
Copy link
Contributor

Currently we have the same config in shortcode_name/config.php and shortcode_name/shortcode.php

i understand that this was done to allow shortcode work without JS Composer, but, how often we use shortcodes without JS Composer plugin?

is it possible to use vc_map_get_attributes() instead of shortcode_atts() in shortcode.php

@yuriipavlov yuriipavlov added invalid This doesn't seem right question Further information is requested labels Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants