Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum cross chain example #4

Merged
merged 35 commits into from
May 17, 2024
Merged

Arbitrum cross chain example #4

merged 35 commits into from
May 17, 2024

Conversation

anajuliabit
Copy link
Member

@anajuliabit anajuliabit commented May 15, 2024 •
edited
Loading

  • ArbitrumProposal_01 inherits from ArbitrumProposal and updates the WETH Gateway on Arbitrum One
  • ArbitrumProposal_02 inherits from ArbitrumProposal and updates the WETH Gateway on Ethereum

@anajuliabit anajuliabit changed the base branch from main to feat/test-cleanup May 15, 2024 20:29
Base automatically changed from feat/test-cleanup to main May 15, 2024 20:52
@anajuliabit anajuliabit marked this pull request as draft May 15, 2024 23:46
@ElliotFriedman ElliotFriedman mentioned this pull request May 16, 2024
Merged
@anajuliabit anajuliabit requested a review from prat-gpt May 16, 2024 22:37
ElliotFriedman
ElliotFriedman reviewed May 17, 2024
View reviewed changes
src/proposals/ArbitrumProposal.sol Outdated
function getScheduleTimelockCaldata()
public
view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@github-actions GitHub Actions
Copy link

Proposal output for src/proposals/arbitrum/ArbitrumProposal_02.sol:

------------------ Proposal Actions ------------------
  1). calling 0x3ffFbAdAF827559da092217e474760E2b2c3CeDd with 0 eth and 0x1cff79cd000000000000000000000000a98dec0c8e0326756c956033bbf091081986d0ed00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000064e17f52e90000000000000000000000009ad46fac0cf7f790e5be05a0f15223935a0c0ada000000000000000000000000d92023e9d9911199a6711321d1277285e6d4e2db0000000000000000000000006801e4888a91180238a8c36594ec65797ec2dddf00000000000000000000000000000000000000000000000000000000 data.
  target: 0x3ffFbAdAF827559da092217e474760E2b2c3CeDd
payload
  0x1cff79cd000000000000000000000000a98dec0c8e0326756c956033bbf091081986d0ed00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000064e17f52e90000000000000000000000009ad46fac0cf7f790e5be05a0f15223935a0c0ada000000000000000000000000d92023e9d9911199a6711321d1277285e6d4e2db0000000000000000000000006801e4888a91180238a8c36594ec65797ec2dddf00000000000000000000000000000000000000000000000000000000
  

  

------------------ Proposal Calldata ------------------
  0x7d5e81e2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000003e00000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000006400000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000264928c169a000000000000000000000000e6841d92b0c345144506576ec13ecf5103ac7f49000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000001e401d5062a0000000000000000000000003fffbadaf827559da092217e474760e2b2c3cedd000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000bb89aca7edae8f1a257ce58392bd8d38e7443210ca91e86d2b3d4384bfcc8a14000000000000000000000000000000000000000000000000000000000003f48000000000000000000000000000000000000000000000000000000000000000e41cff79cd000000000000000000000000a98dec0c8e0326756c956033bbf091081986d0ed00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000064e17f52e90000000000000000000000009ad46fac0cf7f790e5be05a0f15223935a0c0ada000000000000000000000000d92023e9d9911199a6711321d1277285e6d4e2db0000000000000000000000006801e4888a91180238a8c36594ec65797ec2dddf00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002a546869732070726f706f73616c20757067726164657320746865204c312077657468206761746577617900000000000000000000000000000000000000000000

## Setting up 1 EVM.

==========================

Chain 1

Estimated gas price: 7.529556624 gwei

Estimated total gas used for script: 298671

Estimated amount required: 0.002248860206446704 ETH

==========================

SIMULATION COMPLETE. To broadcast these transactions, add --broadcast and wallet configuration(s) to the previous command. See forge script --help for more.

Transactions saved to: /home/runner/work/fps-example-repo/fps-example-repo/broadcast/ArbitrumProposal_02.sol/1/dry-run/run-latest.json

Sensitive values saved to: /home/runner/work/fps-example-repo/fps-example-repo/cache/ArbitrumProposal_02.sol/1/dry-run/run-latest.json

ElliotFriedman
ElliotFriedman approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElliotFriedman ElliotFriedman merged commit 0e88908 into main May 17, 2024
4 checks passed
@ElliotFriedman ElliotFriedman deleted the arbitrum-cross-chain-example branch May 17, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElliotFriedman ElliotFriedman ElliotFriedman approved these changes

@prat-gpt prat-gpt Awaiting requested review from prat-gpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anajuliabit @ElliotFriedman