Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove omniauth-facebook #104

Open
DanielePalombo opened this issue Aug 16, 2022 · 2 comments
Open

Remove omniauth-facebook #104

DanielePalombo opened this issue Aug 16, 2022 · 2 comments

Comments

@DanielePalombo
Copy link
Contributor

DanielePalombo commented Aug 16, 2022

omniauth-facebook extension downgrades omniauth lesser than V2. Rather than lock omniauth version, we think it would be better to remove omniauth-facebook gem and the commit that lock the omniauth version so that the user can add it back manually if required.

ref #102 (comment)
9bc5e05

@piyushswain
Copy link
Contributor

On further investigation, the problem now seems to be with the omniauth gem instead of the omniauth-facebook gem.
Some breaking changes were introduced in omniauth for v2.0 (changelog) which have resulted in failing sign_in_specs.

This issue appears only in omniauth versions >= 2.0. Solidus Social is still working fine for omniauth version 1.9.1.

@piyushswain
Copy link
Contributor

Screenshot 2022-08-17 at 3 50 48 PM
This is the error when clicking on a social login option on the login page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants