From eb6026b90ff6a40a8802be3fc00cdda1c780fd95 Mon Sep 17 00:00:00 2001 From: fanquake Date: Tue, 20 Sep 2022 12:04:43 +0100 Subject: [PATCH] build: remove strings.h from header checks We don't include strings.h anywhere. This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during ./configure. --- build_msvc/bitcoin_config.h.in | 3 --- configure.ac | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/build_msvc/bitcoin_config.h.in b/build_msvc/bitcoin_config.h.in index 5f715282eb0ac..dad44e6228384 100644 --- a/build_msvc/bitcoin_config.h.in +++ b/build_msvc/bitcoin_config.h.in @@ -152,9 +152,6 @@ /* Define to 1 if you have the header file. */ #define HAVE_STDLIB_H 1 -/* Define to 1 if you have the header file. */ -#define HAVE_STRINGS_H 1 - /* Define to 1 if you have the header file. */ #define HAVE_STRING_H 1 diff --git a/configure.ac b/configure.ac index 39dc3b980bdb8..3791385a669bd 100644 --- a/configure.ac +++ b/configure.ac @@ -1010,7 +1010,7 @@ if test "$TARGET_OS" = "darwin"; then AX_CHECK_LINK_FLAG([-Wl,-bind_at_load], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-bind_at_load"], [], [$LDFLAG_WERROR]) fi -AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdio.h stdlib.h unistd.h strings.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h]) +AC_CHECK_HEADERS([endian.h sys/endian.h byteswap.h stdio.h stdlib.h unistd.h sys/types.h sys/stat.h sys/select.h sys/prctl.h sys/sysctl.h vm/vm_param.h sys/vmmeter.h sys/resources.h]) AC_CHECK_DECLS([getifaddrs, freeifaddrs],[CHECK_SOCKET],, [#include