feat: add can_access parameter to list_created_after and update its u…

…sage
someengineering · Oct 22, 2024 · bdad361 · bdad361
1 parent 5c778e4
commit bdad361
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/fixbackend/cloud_accounts/azure_subscription_repo.py b/fixbackend/cloud_accounts/azure_subscription_repo.py
@@ -120,11 +120,12 @@ async def get_by_tenant(self, tenant_id: WorkspaceId) -> Optional[AzureSubscript
 
             return entity.to_model()
 
-    async def list_created_after(self, time: datetime) -> List[AzureSubscriptionCredentials]:
+    async def list_created_after(self, time: datetime, can_access_azure_account: Optional[bool] = None) -> List[AzureSubscriptionCredentials]:
         async with self._session_maker() as session:
-            query = select(AzureSubscriptionCredentialsEntity).filter(
-                AzureSubscriptionCredentialsEntity.created_at > time
-            )
+            filters = [AzureSubscriptionCredentialsEntity.created_at > time]
+            if can_access_azure_account is not None:
+                filters.append(AzureSubscriptionCredentialsEntity.can_access_azure_account.is_(can_access_azure_account))
+            query = select(AzureSubscriptionCredentialsEntity).filter(*filters)
             result = await session.execute(query)
             return [entity.to_model() for entity in result.scalars()]
 

diff --git a/fixbackend/cloud_accounts/azure_subscription_service.py b/fixbackend/cloud_accounts/azure_subscription_service.py
@@ -139,7 +139,8 @@ async def _import_subscriptions(self, creds: AzureSubscriptionCredentials) -> No
 
     async def _ping_new_subscriptions(self) -> None:
         created_less_than_30_minutes_ago = await self.azure_subscriptions_repo.list_created_after(
-            utc() - timedelta(minutes=30)
+            utc() - timedelta(minutes=30),
+            can_access_azure_account=False
         )
 
         async with asyncio.TaskGroup() as tg: