Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to store MemberRole name on-chain #14

Open
maxsam4 opened this issue Sep 12, 2018 · 1 comment
Open

No need to store MemberRole name on-chain #14

maxsam4 opened this issue Sep 12, 2018 · 1 comment
Labels
good first issue help wanted optimization Issues which are not bugs but can improve performance or readability pending to merge Pending to merge into master branch
Milestone
0.8

Comments

@maxsam4
Copy link
Contributor

maxsam4 commented Sep 12, 2018

rather than storing bytes32[] memberRoles and using it's length, we can just store a uint to store the number of memberRoles. The member role names can be read form events.
@maxsam4 maxsam4 added help wanted good first issue optimization Issues which are not bugs but can improve performance or readability labels Sep 12, 2018
@maxsam4 maxsam4 modified the milestones: 0.7, 0.8 Sep 18, 2018
@tech-somish tech-somish added the pending to merge Pending to merge into master branch label Mar 5, 2019
@reemaSomish
Copy link

Hi @maxsam4 ! Thank you for informing us, we are checking the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted optimization Issues which are not bugs but can improve performance or readability pending to merge Pending to merge into master branch
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
3 participants
@maxsam4 @tech-somish @reemaSomish