This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Fix module naming typo in multi-module and multi-module-not-on-root-with-correct-config tests.
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Khodabakhsh
changed the title
multi-module-not-on-root-with-correct-config test.
SBT automatically assigns module names equal to the val name if the `name` property is omitted. Leverage this for modules `module1` and `module2`.
Daniel-Khodabakhsh
changed the title
multi-module-not-on-root-with-correct-config test.multi-module and multi-module-not-on-root-with-correct-config tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module names were mixed up in a few places in
src/sbt-test/sbt-sonar/:multi-module: Removed explicitnameassignment because it matches the modulevalname, which SBT will automatically assign as the name as per the documentation.multi-module-not-on-root-with-correct-config: Fixed the names used for the modules.