Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update folder structure and conversion process #256

Closed
wants to merge 5 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Sep 28, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR updates the folder structure and conversion process in the plugin to address the user's suggestion. Instead of using a "ready" folder and a "backup" folder, the plugin now uses a "source" folder and an "output" folder. The original notes in the "source" folder are considered the "source of truth" and are not modified during the conversion process. The converted notes are placed in the "output" folder. Additionally, error handling has been implemented to log conversion errors in the Obsidian console or in the frontmatter/header of the corresponding file in the output folder. The PR also includes the ability to define multiple source/output folder pairs for users with multiple Jekyll blogs.

Summary of Changes

  • Updated the settings to include "source" and "output" folders instead of "ready" and "backup" folders.
  • Modified the conversion process to read from the "source" folder and write to the "output" folder.
  • Implemented error handling to log conversion errors in the Obsidian console or in the frontmatter/header of the corresponding file in the output folder.
  • Added the ability to define multiple source/output folder pairs for users with multiple Jekyll blogs.

Fixes #255.


🎉 Latest improvements to Sweep:


💡 To get Sweep to edit this pull request, you can:

  • Leave a comment below to get Sweep to edit the entire PR
  • Leave a comment in the code will only modify the file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9158da3) 95.34% compared to head (08438e3) 95.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          11       11           
  Lines         172      172           
  Branches       24       24           
=======================================
  Hits          164      164           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songkg7 songkg7 closed this Oct 1, 2023
@songkg7 songkg7 deleted the sweep/update-folder-structure branch February 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why have a "ready" folder if it's supposed to be "Write once, convert to multiple platforms."
2 participants