Error on Inbound routing entry create on BMv2; P4

[aputriax]

There is an error on inbound routing create on BMv2:
[bmv2] [E] [thread 15] [P4Runtime] Invalid match type

This behavior is introduced by PR #194.
And after a closer look at this PR we found one more issue:
In the pipeline, inbound_routing is applied right after choosing a direction with direction_lookup. We don’t have any ENI associated with the packet at this stage. And the packet eventually would be dropped, no matter what we configured.

In the main branch all inbound related tests are disabled. So I've created a branch for reproducing this issue. It contains a single extra test module - DASH/test/test-cases/functional/ptf/saidasheni_in.py. Here is the link. Use standard procedure to run the tests. But instead of make run-all-tests do the following:

make run-saithrift-client-bash
cd functional/ptf
ptf --test-dir . --pypath /SAI/ptf --interface 0@veth1 --interface 1@veth3 saidasheni_in

In the switch tab you'll see the error I mentioned:
[04:57:51.621] [bmv2] [E] [thread 17] [P4Runtime] Invalid match type

NOTE: This issue is opened as a follow up for the Issue #233

[chrispsommers]

@marian-pritsak Can you provide an explanation for this error and is there a work item or potential remedy? it breaks test cases and we have to skip them. Thanks.

[chrispsommers]

@marian-pritsak Didn't you fix this in a PR?

[KrisNey-MSFT]

Hi @r12f - given our Inbound Routing convo recently, is this one still an issue?
TY, Kristina

[KrisNey-MSFT]

Discuss w/Community whether this is still a problem. Originally from PLVision; @ashutosh-agrawal do you guys still want to own this Issue?

[ashutosh-agrawal]

@KrisNey-MSFT I'll take a look at this issue in the next couple of days and will get back to you.

[KrisNey-MSFT]

@KrisNey-MSFT I'll take a look at this issue in the next couple of days and will get back to you.

thank you!

[KrisNey-MSFT]

still needed; bug in P4 code

[ashutosh-agrawal]

I ran this test yesterday and the P4 issue is fixed but the test is still failing. I fixed some initial issues, but it needs further debugging. @KrisNey-MSFT You can assign this issue to me.

[ashutosh-agrawal]

Opened this PR that fixes the issue with programming of inbound routing table.

[KrisNey-MSFT]

Opened this PR that fixes the issue with programming of inbound routing table.

So ok to close this one @ashutosh-agrawal ?

[ashutosh-agrawal]

My PR #534 fixed this issue for tests in saidasheni.py and PR #545 will take of remaining tests in saidashvnet.py. I think we can close it.