Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to resize on DRM backends #65

Open
ghost opened this issue Apr 12, 2021 · 6 comments
Open

Support to resize on DRM backends #65

ghost opened this issue Apr 12, 2021 · 6 comments
Labels
bug Something isn't working drm Topics of DRM backend

Comments

@ghost
Copy link

ghost commented Apr 12, 2021

If the resolution of the display changes while displaying the screen with the EGLStream backend, the screen display is not updated.
@ghost ghost added bug Something isn't working drm Topics of DRM backend labels Apr 12, 2021
@ghost ghost self-assigned this Apr 12, 2021
@ghost ghost mentioned this issue Apr 12, 2021
Merged
@ghost ghost changed the title Display resolution change is not reflected with the EGLStream backend. Display resolution change is not reflected with the DRM backend. Apr 12, 2021
@HidenoriMatsubayashi
Copy link
Contributor

HidenoriMatsubayashi commented Apr 12, 2021 •
edited
Loading

This problem will happen both GBM and EGLStream. We need to implement it correctly.

@HidenoriMatsubayashi HidenoriMatsubayashi changed the title Display resolution change is not reflected with the DRM backend. Doesn't display correctly when display resolution is changed with DRM backends Apr 12, 2021
@ghost
Copy link
Author

ghost commented Apr 21, 2021

I will start deal with this issue.

@HidenoriMatsubayashi
Copy link
Contributor

Can you fix GBM first? I think it is easier than EGLStream.

@ghost
Copy link
Author

ghost commented Apr 21, 2021

Yes, I will fix GBM first.

@HidenoriMatsubayashi HidenoriMatsubayashi changed the title Doesn't display correctly when display resolution is changed with DRM backends Support to resize on DRM backends Apr 21, 2021
@HidenoriMatsubayashi
Copy link
Contributor

HidenoriMatsubayashi commented Apr 21, 2021 •
edited
Loading

We need to detect to change a DRM connector first. After that, if the display resolution is changed and the new resolution is smaller than the current frame buffer size, we need to resize. If the new resolution is larger than the current frame buffer size, we don't need to do that, which means the frame buffer is the same size.

@ghost ghost mentioned this issue May 7, 2021
Merged
@HidenoriMatsubayashi
Copy link
Contributor

TODO: add resize support for DRM-EGLStream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working drm Topics of DRM backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HidenoriMatsubayashi