Title: Implement Distributed Circuit Breaker (#70) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature/redis-circuit-breaker * feature/redis-circuit-breaker * Refactor * save state * Saving half-open state also * Saving half-open state also * Added test case * Saving state transition * Pass context * Moved redis circuit breaker to v2 * Revert go.mod and go.sum * Acked review comments * Refactor * Refactor --------- Co-authored-by: Kalpit Pant <[email protected]>
call-stack
reviewed
Nov 20, 2024
Comment on lines
+17
to
+20
| type SharedStateStore interface { | ||
| GetState(ctx context.Context) (SharedState, error) | ||
| SetState(ctx context.Context, state SharedState) error | ||
| } |
There was a problem hiding this comment.
How will implementations of this interface know which circuit breaker's state to get/set without an identifier? In a distributed system, we'd likely have multiple circuit breakers running simultaneously.
Should we consider adding a name parameter to distinguish between different circuit breakers?
Additionally, Should we decouple SharedState from the storage interface?
Current interface tightly couples the storage implementation to our SharedState struct:
What if we made this more generic? For example:
GetState(ctx context.Context, name string) ([]byte, error)
SetState(ctx context.Context, name string, data []byte) error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature/redis-circuit-breaker
feature/redis-circuit-breaker
Refactor
save state
Saving half-open state also
Saving half-open state also
Added test case
Saving state transition
Pass context
Moved redis circuit breaker to v2
Revert go.mod and go.sum
Acked review comments
Refactor
Refactor