-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature Activation Bias Correction #1256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad-c
requested changes
Nov 4, 2024
model_compression_toolkit/core/common/framework_implementation.py
Outdated
Show resolved
Hide resolved
...ssion_toolkit/core/common/statistics_correction/apply_activation_bias_correction_to_graph.py
Outdated
Show resolved
Hide resolved
...ssion_toolkit/core/common/statistics_correction/apply_activation_bias_correction_to_graph.py
Outdated
Show resolved
Hide resolved
...ssion_toolkit/core/common/statistics_correction/apply_activation_bias_correction_to_graph.py
Outdated
Show resolved
Hide resolved
...ssion_toolkit/core/common/statistics_correction/apply_activation_bias_correction_to_graph.py
Outdated
Show resolved
Hide resolved
...oolkit/core/keras/statistics_correction/keras_compute_activation_bias_correction_of_graph.py
Show resolved
Hide resolved
...it/core/pytorch/statistics_correction/pytorch_compute_activation_bias_correction_of_graph.py
Outdated
Show resolved
Hide resolved
...it/core/pytorch/statistics_correction/pytorch_compute_activation_bias_correction_of_graph.py
Outdated
Show resolved
Hide resolved
tests/keras_tests/feature_networks_tests/feature_networks/activation_bias_correction_test.py
Show resolved
Hide resolved
tests/pytorch_tests/model_tests/feature_models/activation_bias_correction_test.py
Show resolved
Hide resolved
elad-c
requested changes
Nov 6, 2024
...ion_toolkit/core/common/statistics_correction/compute_activation_bias_correction_of_graph.py
Show resolved
Hide resolved
...ion_toolkit/core/common/statistics_correction/compute_activation_bias_correction_of_graph.py
Outdated
Show resolved
Hide resolved
...ion_toolkit/core/common/statistics_correction/compute_activation_bias_correction_of_graph.py
Outdated
Show resolved
Hide resolved
tests/pytorch_tests/model_tests/feature_models/activation_bias_correction_test.py
Show resolved
Hide resolved
tests/keras_tests/feature_networks_tests/feature_networks/activation_bias_correction_test.py
Outdated
Show resolved
Hide resolved
elad-c
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Activation Bias Correction feature calculates the quantization error from activation quantization and "corrects" it in the next layer's bias.
The feature is set to False by default.
Checklist before requesting a review: