Use context manager to avoid permission error on Windows #865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
The Model Compression Toolkit appears to have a bug on Windows caused by trying to remove a file that is still open. Linux allows for deleting a file that is still open, but Windows is much more particular about this operation and in general trying to remove a file that is still open somewhere will result in a
PermissionError
. Here's a standalone reproduction of the fundamental problem:I can confirm that changing the affected code inside of MCT to
os.close()
the handle before callingos.remove()
does resolve the problem, but I have written this PR to usetempfile.NamedTemporaryFile
as a context manager, which handles close/removal of the file automatically, and will also clean up the file if an error occurs during export.Checklist before requesting a review: