Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confused about residual in attention #4

Open
xuesongwang opened this issue Mar 18, 2020 · 0 comments
Open

confused about residual in attention #4

xuesongwang opened this issue Mar 18, 2020 · 0 comments

Comments

@xuesongwang
Copy link

xuesongwang commented Mar 18, 2020 •
edited
Loading

Hi,
Thanks for your implementation!
I am a little confused about result = t.cat([residual, result], dim=-1) in line 205 as you mentioned very important. Why do you need to concatenate the original residual result ?
@xuesongwang xuesongwang changed the title a typo in attention module confused about residual in attention Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xuesongwang