Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 Separate initialize from the soroswap-aggregator-adapter-interface #36

Open
joaquinsoza opened this issue Jul 10, 2024 · 2 comments
Open
Assignees

Comments

@joaquinsoza
Copy link
Collaborator

joaquinsoza commented Jul 10, 2024

Separate initialize from the soroswap-aggregator-adapter-interface and add it as a independent trait inside the adapter

Why?
In the future another adapter could need more initialization options and we will be held back by the adapter-interface, so i think is better for us to take out the initialize from the interface trait and define it as a separate Trait inside the adapter.

An example can be found in the DeFindex adapters

@joaquinsoza joaquinsoza converted this from a draft issue Jul 10, 2024
@esteblock
Copy link
Member

Please comment with Runtime Verification before addressing this issue.

@esteblock
Copy link
Member

Or use a vec of values...

@chopan123 chopan123 changed the title Separate initialize from the soroswap-aggregator-adapter-interface 1 Separate initialize from the soroswap-aggregator-adapter-interface Aug 19, 2024
@joaquinsoza joaquinsoza self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Wont Do It (for now?)
Development

No branches or pull requests

2 participants