Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 Feature aggregator paths on swap details #526

Closed
MattPoblete opened this issue Aug 22, 2024 · 2 comments · Fixed by #531
Closed

1 Feature aggregator paths on swap details #526

MattPoblete opened this issue Aug 22, 2024 · 2 comments · Fixed by #531
Assignees

Comments

@MattPoblete
Copy link
Collaborator

Currently when a swap is made using the aggregator the swap details don't show the path, we should implement a custom solution for this case that displays all the aggregator paths and their distribution.
image

Goal:
image

@esteblock esteblock changed the title Feature aggregator paths on swap details 1 Feature aggregator paths on swap details Aug 26, 2024
@MattPoblete MattPoblete linked a pull request Aug 28, 2024 that will close this issue
@esteblock esteblock self-assigned this Aug 28, 2024
@esteblock
Copy link
Member

@MattPoblete
We still need info with which Protocol is going

Image

XLM >USDC > (100%)

should be

Soroswap XLM >USDC > (100%)

Also in modal is not being shown!!!!!

Image

@esteblock
Copy link
Member

Hello @MattPoblete when is passing thorugh the Aggregator seems OK
image
image

HOWEVER

In Mainnet (without aggregator) is not showing incorrectly!

image
image

TASKS

  • Fix when is not using aggregator (currently on Mainnet)

@github-project-automation github-project-automation bot moved this from To TEST to Done in Soroswap.Finance Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants