Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Liquidty Providers in Pool Level #78

Open
esteblock opened this issue Oct 23, 2024 · 21 comments
Open

Show Liquidty Providers in Pool Level #78

esteblock opened this issue Oct 23, 2024 · 21 comments
Labels
good first issue Good for newcomers ODHack9

Comments

@esteblock
Copy link
Member

In Pool page, add tab called "Liquidity Providers"
Show "Account (with link to address in stellar expert)", "TVL", "Pool share"

@omsant02
Copy link
Contributor

omsant02 commented Oct 29, 2024

i would like to take this issue @esteblock

would solve this by adding a new column "Liquidity Providers" in the pool page

@esteblock
Copy link
Member Author

i would like to take this issue @esteblock

would solve this by adding a new column "Liquidity Providers" in the pool page

Hello @omsant02 I have not seen any draft PR. Do you hav something?
If not, I will assign other dev.
If you have any question please reach on Discord https://discord.com/invite/G8c98rhfqw

@omsant02
Copy link
Contributor

omsant02 commented Nov 1, 2024

hey i'm working on the issue,
most probably by tonight i'll raise the pr

@esteblock
Copy link
Member Author

hey i'm working on the issue, most probably by tonight i'll raise the pr

I want to see your progress as a draft PR please, otherwise it will be considered as not developed

@omsant02
Copy link
Contributor

omsant02 commented Nov 1, 2024

yep i understand, please give me some time, i'm currently outside of my home, will raise pr as soon as i get back

@esteblock
Copy link
Member Author

Hello @omsant02 the PR is not ready, I will asign someone else

@omsant02
Copy link
Contributor

omsant02 commented Nov 4, 2024

hi @esteblock ,

i was also working on issue # 81 and there i have raised the final pr and also asked you for a review,

i thought first we would be finalising issue #81 and then we would go for this issue

@omsant02
Copy link
Contributor

omsant02 commented Nov 4, 2024

can you please look the issue #81 and the pr i have raised for it,
i think after #81 it will be eaisy for me to complete this issue,
and it's a request please let me complete this issue

@esteblock
Copy link
Member Author

can you please look the issue #81 and the pr i have raised for it, i think after #81 it will be eaisy for me to complete this issue, and it's a request please let me complete this issue

81 was quite easy, what about this one?

@omsant02
Copy link
Contributor

omsant02 commented Nov 4, 2024

yep thanks for merging it,
issue #78 will be completed by the end of the day

@omsant02
Copy link
Contributor

omsant02 commented Nov 6, 2024

hi @esteblock the pr is ready,
please review it
thanks

@esteblock
Copy link
Member Author

esteblock commented Nov 13, 2024

@omsant02 I pulled your PR into a new branch as a draft PR so we can continue from there
#87

I will close your PR, as it is not complete and I will unasgin you until we get someone that can edit the indexer in https://github.com/soroswap/zephyr-programs so we can get a list of liquidity providers

However, thanks for your contribution!

Check discussion in #84

@omsant02
Copy link
Contributor

yep, thanks

@esteblock esteblock added the good first issue Good for newcomers label Nov 13, 2024
@esteblock
Copy link
Member Author

First lets finish soroswap/zephyr-programs#37

@kallis312
Copy link

Let me try this one!

@Awointa
Copy link

Awointa commented Dec 12, 2024

Can I take this issue?

@DuendexCR
Copy link

Could I take a shot at this?

@mimisavage
Copy link

I’m interested in this one.

@lalitkumawat1m
Copy link

Mind if I try this one?

@michojekunle
Copy link

Can I work on this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack9
Projects
Status: Todo
Development

No branches or pull requests

9 participants