Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 getRoutes should be called before iterations #24

Closed
esteblock opened this issue Aug 26, 2024 · 3 comments · Fixed by #26
Closed

1 getRoutes should be called before iterations #24

esteblock opened this issue Aug 26, 2024 · 3 comments · Fixed by #26
Assignees
@esteblock @MattPoblete

Comments

@esteblock
Copy link
Member

Currently in src/router/router, routeSplit() and router() call a lot of times to routeExactIn or routeExactOut.
Each of these functions will call _getAllRoutes

_getAllRoutes should be called before the iterations
@esteblock esteblock changed the title getRoutes should be called before iterations 1 getRoutes should be called before iterations Aug 26, 2024
@MattPoblete MattPoblete moved this from Todo to In Progress in Soroswap.Finance Aug 26, 2024
@MattPoblete MattPoblete linked a pull request Aug 26, 2024 that will close this issue
🩹Fix unnecesary multiple calls on _getAllRoutes function #26
Merged
@MattPoblete
Copy link
Contributor

Fixed on PR #26, tested with jest

@MattPoblete
Copy link
Contributor

Remember to create an issue when merge to update the fontend calls

@esteblock esteblock self-assigned this Aug 27, 2024
@github-project-automation github-project-automation bot moved this from To TEST to Done in Soroswap.Finance Aug 28, 2024
@esteblock
Copy link
Member Author

Included in Frontend soroswap-router-sdk": "^1.2.13
soroswap/frontend#533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esteblock esteblock

@MattPoblete MattPoblete

Labels
None yet
Projects
Soroswap.Finance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹Fix unnecesary multiple calls on _getAllRoutes function soroswap/soroswap-router-sdk
2 participants
@esteblock @MattPoblete