Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace escape with encodeURIComponent #1058

Open
EshaanAgg opened this issue Jun 28, 2024 · 4 comments
Open

Replace escape with encodeURIComponent #1058

EshaanAgg opened this issue Jun 28, 2024 · 4 comments

Comments

@EshaanAgg
Copy link
Contributor

We make use of the browser's escape function at numerous places in our codebase, which has been marked as deprecated. We should probably port to encodeURIComponent to ensure future compatibility and avoid breaking changes.

@Mamatha1718
Copy link

I would like to tackle this issue. I am beginner to open source. I understand this issue, Replace escape with encodeURIComponent, can you please assign to me. and will you please tell me where should i start working up on this.
thank you.

@PhilippWendler
Copy link
Member

You can just start, there is no need to be assigned to an issue on GitHub. The code this issue refers to is all in the benchexec/table-generator/react-table directory.

@Mamatha1718
Copy link

Dear @PhilippWendler ,

I would like to sincerely apologize for the confusion earlier. I am new to open-source contribution, and I was trying to clean up the files and restore them, but unfortunately, I made some mistakes. My prettier is not working properly, and I tried my best to make the necessary changes, but I understand that it was not up to the required standard.

I assure you that I will not repeat these mistakes in the future. I have now deleted the previous pull requests and am working on creating a new one with only the necessary changes. I am also addressing another issue related to the error counts generated in the table summary.

Once again, I apologize for the inconvenience, and if any changes are still required, please let me know. I will make the necessary corrections and proceed accordingly.

Thank you for your understanding and patience.
Mamatha.

@Mamatha1718
Copy link

Hi @PhilippWendler , The PR is ready for review #1149 ,I make a PR with proper changes (not adding any unnecessary changes) and I'm also check correctly use Prettier.
Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants