Feature request: hover results on clang #includes paths

[northyg]

Feature request description

Filing this feature request on behalf of a customer. Essentially in this case C/C++ files are not showing their corresponding files because customer is using relative paths.

Example that doesn't work because of the path:
#include <../dir1/file.cc>

Because of this, the def/finds refs popup does not work.

It's my understanding that this functionality works in similar products to Sourcegraph, such as OpenGrok. Having this functionality would be incredibly useful!

[leahnp]

This is something that gets requested a lot at our firm, it would be great to get it in a future release

[lguychard]

@northyg this came up in triage, and I'm trying to understand what the original issue is.

I'm a bit confused, because the issue title mentions supporting relative paths in .gitmodule, but the issue description mentions a relative path that would live in a source file (c/cpp #include directive). In neither case is the connection to the code intelligence popup super clear.

Is this about:

1. Not being able to click through to submodules from the repository view / file tree when they are specified as relative paths in .gitmodule? (eg. the documented limitation from our docs that we currently do not support relative path setups for submodules, which is orthogonal from code intel).
2. Not being able to see hovers / defs / refs for symbols that are defined in files imported with relative paths (and whose relative paths are in submodules?). If so, would that be with precise code intelligence (through lsif-clang?), or search-based intelligence?

Thanks!

[macraig]

@northyg @alexfogg resurfacing this thread as per @lguychard 's comment above it's a bit unclear where this should fall in terms of ownership. Thanks!

[DaedalusG]

Giving this a quick refresher --

To re-summarize in languages like Java we can resolve hovers for imports, for example:
repo:^github\.com/elastic/elasticsearch$@985a2fb file:^server/src/main/java/org/elasticsearch/index/codec/CodecService\.java
(link)

What is desired here is the same behavior for C includes for example:
repo:^github\.com/tensorflow/tensorflow$ file:^tensorflow/core/graph/validate\.h
(link)

Here a hover on tensorflow/lite/core/c/common.h would ideally allow a user to jump to https://sourcegraph.com/github.com/tensorflow/tensorflow/-/blob/tensorflow/lite/core/c/common.h

Include

File to jump to

@varungandhi-src any chance you can provide insights about the feasibility of implementing this request?

[DaedalusG]

Had a quick chat with Varun -- this feature is on the roadmap for planned work on scip-clang
sourcegraph/scip-clang#2

[varungandhi-src]

Fixed in sourcegraph/scip-clang#166. I will be publishing a scip-clang release next week, which (ahem) includes this.

Example: sourcegraph.com/github.com/ninja-build/ninja/-/blob/src/graph.h?L23:10-23:20#tab=references