Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default folder_mode permissions in nginx_config resource may fail logrotate #622

Open
TimRots opened this issue Jun 14, 2023 · 2 comments
Open

Comments

@TimRots
Copy link

TimRots commented Jun 14, 2023

👻 Brief Description

Currently the nginx_config resource in this cookbook has a folder_mode property which defaults to 0750
and is used for nginx_dir, configs in nginx_dir, and nginx_log_dir permissions.

These defaults can cause issues with the logrotate configuration that is shipped with most Debian (like) OS-es.

A suggestion to omit this issue would be to introduce more fine-grained control over the logdir permissions
by adding properties like log_dir_perm, log_dir_owner, and log_dir_group.

I would like to volunteer for making a fix if I can get some feedback from the maintainers on the how.

🥞 Cookbook version

>= 12.1.0

👩‍🍳 Chef-Infra Version

18.2.7

🎩 Platform details

Ubuntu 20.04 / 22.04

@bmhughes
Copy link
Contributor

Yes adding those properties to nginx_config sounds like the way to go @TimRots , would be happy to accept a PR!

@TimRots
Copy link
Author

TimRots commented Jun 15, 2023

Thank you for the quick reply @bmhughes.
I will try to make time next week to work on this and ask for your review when I have a draft PR ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants