Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual control of LEDs #44

Open
sowbug opened this issue Feb 13, 2017 · 3 comments
Open

Allow individual control of LEDs #44

sowbug opened this issue Feb 13, 2017 · 3 comments

Comments

@sowbug
Copy link
Owner

sowbug commented Feb 13, 2017

The hardware has the capability of individual LED control (not just the RGB composition, but each lamp assembly). Please pipe that capability through to the protocol/tools.

@samccone
Copy link
Collaborator

I went ahead and made a patch here to support it
samccone@98ec349

This change however is somewhat breaking to the API as old 3 byte calls will now set no colors.
Thoughts? (if we do not care about backwards compat happy to open a PR with the existing code).

Thanks!

@reillyeon
Copy link
Collaborator

Have you tested this with the web app? I don't seen an update to the JavaScript code.

If we have to update the protocol for this we could bump the device version (bcdDevice in the descriptor) so that the app can detect it and send the right command.

@samccone
Copy link
Collaborator

Oh I made a new webapp locally that does a few extra things, if you are OK with this patch I can update the existing webapp to use this new protocol.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants