From cafc7c06647257228b00e1bd746bfcb4c9d692ad Mon Sep 17 00:00:00 2001 From: Matthias Schoettle Date: Thu, 14 Mar 2024 10:39:10 -0400 Subject: [PATCH] fix: make REMOTE_ADDR optional in all cases --- easyaudit/signals/auth_signals.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/easyaudit/signals/auth_signals.py b/easyaudit/signals/auth_signals.py index ca3676b4..f8bf9b4d 100644 --- a/easyaudit/signals/auth_signals.py +++ b/easyaudit/signals/auth_signals.py @@ -18,7 +18,7 @@ def user_logged_in(sender, request, user, **kwargs): 'login_type': LoginEvent.LOGIN, 'username': getattr(user, user.USERNAME_FIELD), 'user_id': getattr(user, 'id', None), - 'remote_ip': request.META.get(REMOTE_ADDR_HEADER, "") + 'remote_ip': request.META.get(REMOTE_ADDR_HEADER, '') }) except Exception: if should_propagate_exceptions(): @@ -32,7 +32,7 @@ def user_logged_out(sender, request, user, **kwargs): 'login_type': LoginEvent.LOGOUT, 'username': getattr(user, user.USERNAME_FIELD), 'user_id': getattr(user, 'id', None), - 'remote_ip': request.META[REMOTE_ADDR_HEADER] + 'remote_ip': request.META.get(REMOTE_ADDR_HEADER, '') }) except Exception: if should_propagate_exceptions(): @@ -47,7 +47,7 @@ def user_login_failed(sender, credentials, **kwargs): login_event = audit_logger.login({ 'login_type': LoginEvent.FAILED, 'username': credentials[user_model.USERNAME_FIELD], - 'remote_ip': request.META[REMOTE_ADDR_HEADER] + 'remote_ip': request.META.get(REMOTE_ADDR_HEADER, '') }) except Exception: if should_propagate_exceptions():