Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optifine and dev environment #766

Closed
Barteks2x opened this issue Jul 12, 2017 · 14 comments
Closed

Optifine and dev environment #766

Barteks2x opened this issue Jul 12, 2017 · 14 comments
Labels

Comments

@Barteks2x
Copy link

I know there already is #196. But the way to make it work outlined there doesn't work (anymore?). Optifine loads, but there are no new video settings options, and I doubt it actually does anything (but I'm not sure).

I want to eventually make optifine compatible with my mod, but without being able to run optifine in dev environment it's not going to be possible (and there is nothing optifine can reasonably do about compatibility, it's just conflicting code patches).

@SetantaLP
Copy link

SetantaLP commented Jul 13, 2017

I didn't tested it, but I think the guide in the section below the section mentioned in #196 should work (if you ajust the version-numbers), because as far as I know there are no changes to the way optifine works since then. If not, it might help to post the error-log here so that everyone that wants to help, can see what exactly went wrong.

@Barteks2x
Copy link
Author

Barteks2x commented Jul 13, 2017

I followed that exact section. There is no error. It starts just fine, and optifine appears to be there in F3 debug screen, but there are no new options in video settings.

@Barteks2x
Copy link
Author

I tried with the exact version of forge mentioned in optifine changelog, still the same result. The log:
fml-client-latest.log.txt

@sp614x sp614x added the forge label Jul 13, 2017
@SetantaLP
Copy link

That's strange. Did you replaced the tweak-class as mentioned in the guide? Based on the log, it seams that optifine loads it's normal tweak-class and class-transformer, so it can't inject the classes into the class loader (and I'm quite sure it doesn't inject classes, because there are no log-outputs about the Reflector-Class and about ConnectedTextures, which should appear as far as I know).

@Barteks2x
Copy link
Author

Wait, does the tweaker replacement from the previous section still apply? I didn't know that.

@Barteks2x
Copy link
Author

So that was a proble on my side, I misunderstood the instructions.

@SetantaLP
Copy link

Not really misunderstood, you only skipped the important part: "Again, you'll need to create a class transformer that is able to load it like this."

@Barteks2x
Copy link
Author

I jumped straight to the "OptiFine H5 and beyond" part, ignoring what was before, thinking this is all I need to do for these newer versions.

@SetantaLP
Copy link

Yea, and this section describes all you need to do, including the text I quoted in my previous post (which is the last sentence of the second paragraph of the section "OptiFine H5 and beyond".) The only thing not mentioned in this section is the fact that you need to edit the the transformer-entry in the manifest-file, if you use a class that is named differently.

@Barteks2x
Copy link
Author

I got optifine running in dev environment, but all blocks and items have missing textures. Any idea why?

@Barteks2x Barteks2x reopened this Jul 13, 2017
@Barteks2x
Copy link
Author

Also, it tends to crash when rendering forge fancy missing model:

java.lang.RuntimeException: No OpenGL context found in the current thread.
	at org.lwjgl.opengl.GLContext.getCapabilities(GLContext.java:124)
	at org.lwjgl.opengl.GL11.glBindTexture(GL11.java:651)
	at net.minecraft.client.renderer.GlStateManager.bindTexture(GlStateManager.java:508)
	at net.minecraft.client.renderer.texture.TextureUtil.bindTexture(TextureUtil.java:328)
	at net.minecraft.client.renderer.texture.TextureManager.bindTexture(TextureManager.java:57)
	at net.minecraft.client.gui.FontRenderer.bindTexture(FontRenderer.java:1122)
	at net.minecraft.client.gui.FontRenderer.renderDefaultChar(FontRenderer.java:313)
	at net.minecraft.client.gui.FontRenderer.renderChar(FontRenderer.java:300)
	at net.minecraft.client.gui.FontRenderer.renderStringAtPos(FontRenderer.java:570)
	at net.minecraft.client.gui.FontRenderer.renderString(FontRenderer.java:693)
	at net.minecraft.client.gui.FontRenderer.drawString(FontRenderer.java:428)
	at net.minecraft.client.gui.FontRenderer.drawString(FontRenderer.java:407)
	at net.minecraftforge.client.model.FancyMissingModel$BakedModel.getQuads(FancyMissingModel.java:150)
	at net.minecraft.client.renderer.BlockModelRenderer.renderModelSmooth(BlockModelRenderer.java:115)
	at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.renderModelSmooth(ForgeBlockModelRenderer.java:107)
	at net.minecraft.client.renderer.BlockModelRenderer.renderModel(BlockModelRenderer.java:74)
	at net.minecraft.client.renderer.BlockModelRenderer.renderModel(BlockModelRenderer.java:54)
	at net.minecraft.client.renderer.BlockRendererDispatcher.renderBlock(BlockRendererDispatcher.java:80)
	at net.minecraft.client.renderer.chunk.RenderChunk.rebuildChunk(RenderChunk.java:296)
	at net.minecraft.client.renderer.chunk.ChunkRenderWorker.processTask(ChunkRenderWorker.java:119)
	at net.minecraft.client.renderer.chunk.ChunkRenderWorker.run(ChunkRenderWorker.java:47)
	at java.lang.Thread.run(Thread.java:745)

@sp614x
Copy link
Owner

sp614x commented Jul 13, 2017

This issue belongs in the SimpleDeobf issues: https://github.com/octarine-noise/simpledeobf/issues

@Barteks2x
Copy link
Author

Barteks2x commented Jul 13, 2017

Is it even still maintained?

@sp614x
Copy link
Owner

sp614x commented Jul 13, 2017

Continued in SimpleDeobf: octarine-noise/simpledeobf#3

@sp614x sp614x closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants