Skip to content
Rust

Patches #127

Sign in to view logs

Patches

Patches #127

GitHub Actions / clippy succeeded Feb 3, 2024 in 1s

clippy

39 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 39
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 74 in crates/cmds-solana/src/wormhole/verify_signatures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to use `.enumerate()` and immediately discard the index 

warning: you seem to use `.enumerate()` and immediately discard the index
  --> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31
   |
74 |     for (_tx_index, chunk) in signature_items.chunks(7).enumerate() {
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
   = note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
   |
74 |     for chunk in signature_items.chunks(7) {
   |         ~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 73 in crates/flow-server/src/middleware/auth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

a `const` item should never be interior mutable 

warning: a `const` item should never be interior mutable
  --> crates/flow-server/src/middleware/auth.rs:73:1
   |
73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key");
   | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | make this a static item (maybe with lazy_static)
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
   = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default

Check warning on line 73 in crates/flow-server/src/middleware/auth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

a `const` item should never be interior mutable 

warning: a `const` item should never be interior mutable
  --> crates/flow-server/src/middleware/auth.rs:73:1
   |
73 | pub const X_API_KEY: HeaderName = HeaderName::from_static("x-api-key");
   | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   | |
   | make this a static item (maybe with lazy_static)
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
   = note: `#[warn(clippy::declare_interior_mutable_const)]` on by default

Check warning on line 74 in crates/cmds-solana/src/wormhole/verify_signatures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to use `.enumerate()` and immediately discard the index 

warning: you seem to use `.enumerate()` and immediately discard the index
  --> crates/cmds-solana/src/wormhole/verify_signatures.rs:74:31
   |
74 |     for (_tx_index, chunk) in signature_items.chunks(7).enumerate() {
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
   = note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
   |
74 |     for chunk in signature_items.chunks(7) {
   |         ~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 814 in crates/db/src/connection/conn_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure 

warning: redundant closure
   --> crates/db/src/connection/conn_impl.rs:814:62
    |
814 |         let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>());
    |                                                              ^^^^^^^^^^^ help: replace the closure with the function itself: `Json`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 360 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:360:17
    |
360 |                 let res = self.save_signature(&id, &signature).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 335 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:335:17
    |
335 |                 let res = self.set_node_finish(&id, &node_id, &times, &time).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 330 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:330:17
    |
330 |                 let res = self.push_node_error(&id, &node_id, &times, &error).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 324 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:322:17
    |
322 | /                 let res = self
323 | |                     .save_node_output(&id, &node_id, &times, &output)
324 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
322 ~                 self
323 +                     .save_node_output(&id, &node_id, &times, &output)
324 +                     .await?;
    |

Check warning on line 317 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:315:17
    |
315 | /                 let res = self
316 | |                     .new_node_run(&id, &node_id, &times, &time, &input)
317 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
315 ~                 self
316 +                     .new_node_run(&id, &node_id, &times, &time, &input)
317 +                     .await?;
    |

Check warning on line 310 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:310:17
    |
310 |                 let res = self.set_run_result(&id, &time, &not_run, &output).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 304 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:302:17
    |
302 | /                 let res = self
303 | |                     .push_flow_log(&id, &index, &time, &level, &module, &content)
304 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
302 ~                 self
303 +                     .push_flow_log(&id, &index, &time, &level, &module, &content)
304 +                     .await?;
    |

Check warning on line 296 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:296:17
    |
296 |                 let res = self.push_flow_error(&id, &error).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 291 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:291:17
    |
291 |                 let res = self.set_start_time(&id, &time).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 256 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:256:17
    |
256 |                 let res = self.share_flow_run(id, user).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.share_flow_run(id, user).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
    = note: `#[warn(clippy::let_unit_value)]` on by default

Check warning on line 814 in crates/db/src/connection/conn_impl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure 

warning: redundant closure
   --> crates/db/src/connection/conn_impl.rs:814:62
    |
814 |         let signatures = signatures.map(|arr| arr.iter().map(|p| Json(p)).collect::<Vec<_>>());
    |                                                              ^^^^^^^^^^^ help: replace the closure with the function itself: `Json`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 360 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:360:17
    |
360 |                 let res = self.save_signature(&id, &signature).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.save_signature(&id, &signature).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 335 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:335:17
    |
335 |                 let res = self.set_node_finish(&id, &node_id, &times, &time).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_node_finish(&id, &node_id, &times, &time).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 330 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:330:17
    |
330 |                 let res = self.push_node_error(&id, &node_id, &times, &error).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_node_error(&id, &node_id, &times, &error).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 324 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:322:17
    |
322 | /                 let res = self
323 | |                     .save_node_output(&id, &node_id, &times, &output)
324 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
322 ~                 self
323 +                     .save_node_output(&id, &node_id, &times, &output)
324 +                     .await?;
    |

Check warning on line 317 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:315:17
    |
315 | /                 let res = self
316 | |                     .new_node_run(&id, &node_id, &times, &time, &input)
317 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
315 ~                 self
316 +                     .new_node_run(&id, &node_id, &times, &time, &input)
317 +                     .await?;
    |

Check warning on line 310 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:310:17
    |
310 |                 let res = self.set_run_result(&id, &time, &not_run, &output).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_run_result(&id, &time, &not_run, &output).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 304 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:302:17
    |
302 | /                 let res = self
303 | |                     .push_flow_log(&id, &index, &time, &level, &module, &content)
304 | |                     .await?;
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
help: omit the `let` binding
    |
302 ~                 self
303 +                     .push_flow_log(&id, &index, &time, &level, &module, &content)
304 +                     .await?;
    |

Check warning on line 296 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:296:17
    |
296 |                 let res = self.push_flow_error(&id, &error).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.push_flow_error(&id, &error).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value

Check warning on line 291 in crates/db/src/connection/proxied_user_conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this let-binding has unit value 

warning: this let-binding has unit value
   --> crates/db/src/connection/proxied_user_conn.rs:291:17
    |
291 |                 let res = self.set_start_time(&id, &time).await?;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `self.set_start_time(&id, &time).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
View more details on GitHub Actions