diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ea103a45a39..17c2924813f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,34 @@ ## По какой причине +<<<<<<< HEAD ## Медиа(Видео/Скриншоты) +======= +## Technical details + + +## Media + + +## Requirements + +- [ ] I have read and I am following the [Pull Request Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). I understand that not doing so may get my pr closed at maintainer’s discretion +- [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase + +## Breaking changes +>>>>>>> refs/remotes/wizards/master @@ -22,6 +49,26 @@ + +## Кратное описание + +## По какой причине + +## Медиа(Видео/Скриншоты) +Если ваш PR содержит внутриигровые изменения вы обязаны предоставить скриншоты/видео изменений. + +## Проверки + +- [ ] Я не требую помощи для завершения PR +- [ ] Перед выкладыванием/запросом о рассмотрении PR, Я проверил работоспособность изменений. +- [ ] Я добавил скриншоты/видео изменений, или данный PR не меняет внутриигровые механики +Если нужно чтобы игроки узнали об изменениях сделаных в данном PR укажите их используя шаблон вне коментария. Кратко и информативно. :cl: VigersRay - add: Добавлено веселье. - remove: Удалено веселье. diff --git a/Content.Client/Actions/ActionsSystem.cs b/Content.Client/Actions/ActionsSystem.cs index 6a2f67dc2c5..8f7b8e0788b 100644 --- a/Content.Client/Actions/ActionsSystem.cs +++ b/Content.Client/Actions/ActionsSystem.cs @@ -294,7 +294,7 @@ public void LoadActionAssignments(string path, bool userData) continue; var action = _serialization.Read(actionNode, notNullableOverride: true); - var actionId = Spawn(null); + var actionId = Spawn(); AddComp(actionId, action); AddActionDirect(user, actionId); diff --git a/Content.Client/Administration/AdminNameOverlay.cs b/Content.Client/Administration/AdminNameOverlay.cs index c21ba2e32ca..27b2a5dedb0 100644 --- a/Content.Client/Administration/AdminNameOverlay.cs +++ b/Content.Client/Administration/AdminNameOverlay.cs @@ -44,7 +44,7 @@ protected override void Draw(in OverlayDrawArgs args) } // if not on the same map, continue - if (_entityManager.GetComponent(entity.Value).MapID != _eyeManager.CurrentMap) + if (_entityManager.GetComponent(entity.Value).MapID != args.MapId) { continue; } diff --git a/Content.Client/Administration/UI/Bwoink/BwoinkControl.xaml.cs b/Content.Client/Administration/UI/Bwoink/BwoinkControl.xaml.cs index 64d954331c0..6ca0ace59e1 100644 --- a/Content.Client/Administration/UI/Bwoink/BwoinkControl.xaml.cs +++ b/Content.Client/Administration/UI/Bwoink/BwoinkControl.xaml.cs @@ -97,13 +97,18 @@ public BwoinkControl() if (a.IsPinned != b.IsPinned) return a.IsPinned ? -1 : 1; - // First, sort by unread. Any chat with unread messages appears first. We just sort based on unread - // status, not number of unread messages, so that more recent unread messages take priority. + // First, sort by unread. Any chat with unread messages appears first. var aUnread = ach.Unread > 0; var bUnread = bch.Unread > 0; if (aUnread != bUnread) return aUnread ? -1 : 1; + // Sort by recent messages during the current round. + var aRecent = a.ActiveThisRound && ach.LastMessage != DateTime.MinValue; + var bRecent = b.ActiveThisRound && bch.LastMessage != DateTime.MinValue; + if (aRecent != bRecent) + return aRecent ? -1 : 1; + // Next, sort by connection status. Any disconnected players are grouped towards the end. if (a.Connected != b.Connected) return a.Connected ? -1 : 1; diff --git a/Content.Client/Chemistry/UI/TransferAmountBoundUserInterface.cs b/Content.Client/Chemistry/UI/TransferAmountBoundUserInterface.cs index f1cb27a62a4..1bc1c0dba9a 100644 --- a/Content.Client/Chemistry/UI/TransferAmountBoundUserInterface.cs +++ b/Content.Client/Chemistry/UI/TransferAmountBoundUserInterface.cs @@ -1,4 +1,5 @@ using Content.Shared.Chemistry; +using Content.Shared.Chemistry.Components; using Content.Shared.FixedPoint; using JetBrains.Annotations; using Robust.Client.GameObjects; @@ -9,11 +10,15 @@ namespace Content.Client.Chemistry.UI [UsedImplicitly] public sealed class TransferAmountBoundUserInterface : BoundUserInterface { + private IEntityManager _entManager; + private EntityUid _owner; [ViewVariables] private TransferAmountWindow? _window; public TransferAmountBoundUserInterface(EntityUid owner, Enum uiKey) : base(owner, uiKey) { + _owner = owner; + _entManager = IoCManager.Resolve(); } protected override void Open() @@ -21,6 +26,9 @@ protected override void Open() base.Open(); _window = this.CreateWindow(); + if (_entManager.TryGetComponent(_owner, out var comp)) + _window.SetBounds(comp.MinimumTransferAmount.Int(), comp.MaximumTransferAmount.Int()); + _window.ApplyButton.OnPressed += _ => { if (int.TryParse(_window.AmountLineEdit.Text, out var i)) diff --git a/Content.Client/Chemistry/UI/TransferAmountWindow.xaml b/Content.Client/Chemistry/UI/TransferAmountWindow.xaml index 3d787c69c10..c73d86b10f1 100644 --- a/Content.Client/Chemistry/UI/TransferAmountWindow.xaml +++ b/Content.Client/Chemistry/UI/TransferAmountWindow.xaml @@ -6,6 +6,10 @@ + +