Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity spawn panel preview icon entities aren't paused and don't get reused #5594

Open
Tayrtahn opened this issue Jan 8, 2025 · 0 comments

Comments

@Tayrtahn
Copy link
Member

Tayrtahn commented Jan 8, 2025

The entity spawn panel uses EntityPrototypeViews to generate more accurate icons for the list. These entities are clientside, but they are not set as paused, so they are included in system Update loops. They also don't get reused when a new EntityPrototypeView calls for the same prototype, so more preview entities are continuously spawned as the menu is closed, reopened, and scrolled.

Notably, just pausing the entities after spawning (5bb4fa8) isn't a good fix, as this causes some of the visuals (such as solution fill levels) not to be fully set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant