Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapChunk.Fixtures can contain non-existent fixtures #5596

Open
ElectroJr opened this issue Jan 8, 2025 · 0 comments
Open

MapChunk.Fixtures can contain non-existent fixtures #5596

ElectroJr opened this issue Jan 8, 2025 · 0 comments
Labels
Area: Physics Relating to movement and collisions. Difficulty: 3-Hard Extensive codebase knowledge required. Issue: Bug This issue is a bug report. Priority: 1-Urgent GET ON IT STAT

Comments

@ElectroJr
Copy link
Member

Reported on discord

Can cause the client to freeze due to exceptions while rendering. It'd be easy to turn the dictionary access into a try-get, but that's just hiding some other (potentially also severe) bug under the rug.

System.Collections.Generic.KeyNotFoundException: The given key 'grid_chunk-32'01-0'01' was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Robust.Shared.Map.MapManager.IsIntersecting(ChunkEnumerator enumerator, IPhysShape shape, Transform shapeTransform, Entity`1 grid) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Map/MapManager.Queries.cs:line 29
   at Robust.Shared.Map.MapManager.<>c__65`1.<FindGridsIntersecting>b__65_0(GridQueryState`1& state, Proxy proxy) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Map/MapManager.Queries.cs:line 174
   at Robust.Shared.Physics.B2DynamicTree`1.Query[TState](TState& state, QueryCallback`1 callback, Box2& aabb) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Physics/B2DynamicTree.cs:line 894
   at Robust.Shared.Map.MapManager.FindGridsIntersecting[TState](EntityUid mapEnt, IPhysShape shape, Box2 worldAABB, Transform transform, TState& state, GridCallback`1 callback, Boolean approx, Boolean includeMap) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Map/MapManager.Queries.cs:line 139
   at Robust.Shared.Map.MapManager.FindGridsIntersecting[TState](EntityUid mapEnt, Box2 worldAABB, TState& state, GridCallback`1 callback, Boolean approx, Boolean includeMap) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Map/MapManager.Queries.cs:line 227
   at Robust.Shared.Map.MapManager.FindGridsIntersecting[TState](MapId mapId, Box2 worldAABB, TState& state, GridCallback`1 callback, Boolean approx, Boolean includeMap) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/Map/MapManager.Queries.cs:line 67
   at Robust.Shared.ComponentTrees.ComponentTreeSystem`2.GetIntersectingTrees(MapId mapId, Box2 worldAABB) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/ComponentTrees/ComponentTreeSystem.cs:line 272
   at Robust.Shared.ComponentTrees.ComponentTreeSystem`2.QueryAabb(MapId mapId, Box2Rotated worldBounds, Boolean approx) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/ComponentTrees/ComponentTreeSystem.cs:line 305
   at Content.Client.Gameplay.GameplayStateBase.GetClickableEntities(MapCoordinates coordinates, IEye eye) in /home/runner/work/space-station-14/space-station-14/Content.Client/Gameplay/GameplayStateBase.cs:line 140
   at Content.Client.Sprite.SpriteFadeSystem.FrameUpdate(Single frameTime) in /home/runner/work/space-station-14/space-station-14/Content.Client/Sprite/SpriteFadeSystem.cs:line 56
   at Robust.Shared.GameObjects.EntitySystemManager.FrameUpdate(Single frameTime) in /home/runner/work/RobustToolbox/RobustToolbox/Robust.Shared/GameObjects/EntitySystemManager.cs:line 333
[ERRO] ui: Caught exception while trying to draw a UI element: MainWindowRoot (WindowRoot)

Probably either revealed by, or caused by #5348?

@ElectroJr ElectroJr added Issue: Bug This issue is a bug report. Priority: 1-Urgent GET ON IT STAT Area: Physics Relating to movement and collisions. Difficulty: 3-Hard Extensive codebase knowledge required. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Physics Relating to movement and collisions. Difficulty: 3-Hard Extensive codebase knowledge required. Issue: Bug This issue is a bug report. Priority: 1-Urgent GET ON IT STAT
Projects
None yet
Development

No branches or pull requests

1 participant