-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some HTML content not rendering in some feeds #525
Comments
Thanks for the HTML! That will make it much easier to debug. |
I have similar issues. Links and subheads that are links are removed in the reader view. Any time line for fixing this bug? |
Please don't ask for timelines. This is not my job. |
My apologies. I didn't mean to be demanding. I was just curious. Love your work! |
Now I grant that clicking on the footnote link is "undefined behavior" but the footnote is rendered at the bottom |
Added support for clicking on the footnotes in #567 |
@JoseKilo let's be clear here. Are you perhaps using "Fetch full article" here? |
I was using "Fetch full article" indeed ! I tried with the master version of the App anyway and tried to checkout your #567 branch too just in case. I can confirm they behave the same as the GooglePlay version: they work as expected with "Fetch full article" disabled and the elements disappear when I enable it. Thank you and sorry for the confusion ! I should have included it in the report |
Ah good. Ill see if theres anything wrong or if its all the unsupported javascript thats the cause. But please don't enable Fetch full article unless the feed isn't including the full text in the fees itself. Issues like this is why |
Checklist
App version
2.8.1
Where did you get the app from
Google Play
Android version
10
Device model
No response
First occurred
Not sure
Steps to reproduce
https://www.experimental-history.com/feed
(although most substack feeds seem affected)Open items by default with
->Reader
How to feel bad and be wrong
(although most articles in that feed should be affected too)Expected behaviour
Intermediate titles, foot notes and all images should be visible.
Current behaviour
Intermediate titles and foot notes aren't rendered.
If you inspect the feed content manually, an intermediate title looks like this:
So maybe that extra
<strong>
tag could be related.And the foot notes look like:
I understand that making the links work in the Reader itself would be harder. But it could render the text at the bottom like any other text.
Similarly some images are also not rendered, like this one:
So it looks like it's trying to strip html tags and removing some useful content in the process.
Logs
No response
The text was updated successfully, but these errors were encountered: