Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some HTML content not rendering in some feeds #525

Open
4 tasks done
JoseKilo opened this issue Jan 24, 2025 · 11 comments
Open
4 tasks done

Some HTML content not rendering in some feeds #525

JoseKilo opened this issue Jan 24, 2025 · 11 comments
Labels
Type: Confirmed bug Bugs confirmed by maintainer

Comments

@JoseKilo
Copy link

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same bug report.
  • I have also used the search function for CLOSED issues to see if the problem is already solved and just waiting to be released.
  • I will describe the problem with as much detail as possible.
  • If the bug only to occurs with a certain feed, I will include the URL of that feed.

App version

2.8.1

Where did you get the app from

Google Play

Android version

10

Device model

No response

First occurred

Not sure

Steps to reproduce

  1. Add new feed: https://www.experimental-history.com/feed (although most substack feeds seem affected)
  2. Select Open items by default with -> Reader
  3. Open article titled How to feel bad and be wrong (although most articles in that feed should be affected too)
  4. Open the same article in a browser to compare https://www.experimental-history.com/p/how-to-feel-bad-and-be-wrong

Expected behaviour

Intermediate titles, foot notes and all images should be visible.

Current behaviour

Intermediate titles and foot notes aren't rendered.

If you inspect the feed content manually, an intermediate title looks like this:

<h1><strong>HARD QUESTION: AM I WORKING HARD ENOUGH? EASY QUESTION: AM I SUFFERING?</strong></h1>

So maybe that extra <strong> tag could be related.

And the foot notes look like:

<a id="footnote-1" href="#footnote-anchor-1" class="footnote-number" contenteditable="false" target="_self">1</a>
 <div class="footnote-content"><p>
  Technically, there is also no Nobel Prize for economics.
[...]

I understand that making the links work in the Reader itself would be harder. But it could render the text at the bottom like any other text.

Similarly some images are also not rendered, like this one:

This is apparently what everybody else is doing, because you can watch these feelings flip in real time:
</p><div class="captioned-image-container">
 <figure>
  <a class="image-link image2 is-viewable-img" target="_blank" href="https://substackcdn.com/image/fetch/f_auto,q_auto:good,fl_progressive:steep/https%3A%2F%2Fsubstack-post-media.s3.amazonaws.com%2Fpublic%2Fimages%2Fa140b0fe-b678-4ee8-ad36-d04b49626903_626x431.png" data-component-name="Image2ToDOM">
   <div class="image2-inset">
    <picture>
     <source type="image/webp" srcset="https://substackcdn.com/image/fetch/w_424,c_limit,
[...]

So it looks like it's trying to strip html tags and removing some useful content in the process.

Logs

No response

@JoseKilo JoseKilo added the Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet label Jan 24, 2025
@spacecowboy
Copy link
Owner

Thanks for the HTML! That will make it much easier to debug.

@spacecowboy spacecowboy added Type: Confirmed bug Bugs confirmed by maintainer and removed Type: Possible bug Issues that seem to be a bug, but haven't been confirmed yet labels Jan 24, 2025
@cornetth
Copy link

I have similar issues. Links and subheads that are links are removed in the reader view. Any time line for fixing this bug?

@spacecowboy
Copy link
Owner

I have similar issues. Links and subheads that are links are removed in the reader view. Any time line for fixing this bug?

Please don't ask for timelines. This is not my job.

@cornetth
Copy link

I have similar issues. Links and subheads that are links are removed in the reader view. Any time line for fixing this bug?

Please don't ask for timelines. This is not my job.

My apologies. I didn't mean to be demanding. I was just curious. Love your work!

@spacecowboy
Copy link
Owner

Actually I am unable to reproduce this issue. See screenshots. It's possible the upgrades I've done has fixed it but I doubt any changes have been made.

Image
Image
Image

@spacecowboy
Copy link
Owner

Now I grant that clicking on the footnote link is "undefined behavior" but the footnote is rendered at the bottom

@spacecowboy
Copy link
Owner

Added support for clicking on the footnotes in #567

@JoseKilo
Copy link
Author

Thank you for investigating the issue !
I should have added some screenshots to the original report. Adding them now in case they're still useful.

I'm using the latest version from Google Play: 2.8.1.
But I will try with master when I have a moment.

Image
Image
Image

@spacecowboy
Copy link
Owner

@JoseKilo let's be clear here. Are you perhaps using "Fetch full article" here?

@JoseKilo
Copy link
Author

I was using "Fetch full article" indeed !
And yes, if I disable it I can see all the missing elements.
Not sure why I started using that option in all my feeds, I must have seen an issue in some other particular feed. Since I use it all the time by default, I didn't think much about it.

I tried with the master version of the App anyway and tried to checkout your #567 branch too just in case. I can confirm they behave the same as the GooglePlay version: they work as expected with "Fetch full article" disabled and the elements disappear when I enable it.

Thank you and sorry for the confusion ! I should have included it in the report

@spacecowboy
Copy link
Owner

Ah good. Ill see if theres anything wrong or if its all the unsupported javascript thats the cause.

But please don't enable Fetch full article unless the feed isn't including the full text in the fees itself. Issues like this is why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Confirmed bug Bugs confirmed by maintainer
Projects
None yet
Development

No branches or pull requests

3 participants