Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack local preview is slow in large working trees. #289

Open
armooo opened this issue Feb 1, 2025 · 0 comments
Open

Stack local preview is slow in large working trees. #289

armooo opened this issue Feb 1, 2025 · 0 comments

Comments

@armooo
Copy link
Contributor

armooo commented Feb 1, 2025

The ignore options to local preview still stat and process all files in the working tree. In large monorepo or projects with many ignored files, node_module being one common example, just processing the matchFn from GetIgnoreMatcherFn takes most of the time. It looks like the matcher support was added in a fork of archiver here.

One option I see is to change it to return SkipDir in the WalkFunc` if we are skipping a directory. I have tested this out for my example and with #288 the time to create the archive has gone from minutes to milliseconds. If this seems like a good solution to you I can send some PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant