fix: write_column should be a list #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollorion
force-pushed
the
fix-audit-lists
branch
2 times, most recently
from
ab94c2f to
7ec7656
Compare
jmfontaine
requested changes
May 29, 2024
Apollorion
force-pushed
the
fix-audit-lists
branch
from
7ec7656 to
c392eb2
Compare
Apollorion
force-pushed
the
fix-audit-lists
branch
from
c392eb2 to
eb3c98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_column(starting_row, column, data)
write_column writes a column starting at
starting_rowand iterates overdataincrementing the row automaticaly.This change ensures we are always passing in a list, letting the library handle the hard work for us.