Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings during code generation #49

Merged
merged 12 commits into from
Aug 5, 2024

Conversation

Apollorion
Copy link
Member

@Apollorion Apollorion commented Jun 5, 2024

This PR allows us to pass specific settings, with defaults, to our Jinja templates.

Added:

generator:
  spacelift:
    manage_state: bool # Instructs the spacelift stacks to manage state or not
  github:
    custom_app: bool # Instructs Jinja to add a github_enterprise block or not

github_enterprise in a spacelift_stack is meant to be used when setting up a custom github application. Since there is no way for us to know beforehand how they set this up, adding it as a flag to the generator config.

@Apollorion Apollorion changed the title feat: allow setting github_enterprise only when using custom apps feat: settings during code generation Jun 6, 2024
@jmfontaine jmfontaine self-requested a review June 20, 2024 17:40
@Apollorion Apollorion merged commit 3a42508 into main Aug 5, 2024
20 checks passed
@Apollorion Apollorion deleted the fix-github-enterprise-template branch August 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant