Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest.json generation to Packer #43

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

peterdeme
Copy link
Collaborator

Description of the change

First step to automate changelog generation.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme requested a review from TheMacies October 24, 2023 09:46
@peterdeme peterdeme force-pushed the add-manifest-json branch 3 times, most recently from a7e6d13 to da6fc37 Compare October 24, 2023 12:56
TheMacies
TheMacies previously approved these changes Oct 24, 2023
@peterdeme peterdeme force-pushed the add-manifest-json branch 2 times, most recently from 1a4e296 to 59560b1 Compare October 24, 2023 13:01
@peterdeme
Copy link
Collaborator Author

@TheMacies bumped some gh action versions while I was here

@peterdeme peterdeme merged commit 367a71e into main Oct 24, 2023
3 checks passed
@peterdeme peterdeme deleted the add-manifest-json branch October 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants