Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print markdown at the end of the jobs #44

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Print markdown at the end of the jobs #44

merged 1 commit into from
Nov 20, 2023

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Oct 25, 2023 •
edited
Loading

Description of the change

Print the release markdown at the end of the job.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme force-pushed the add-markdown branch 6 times, most recently from de51288 to 4bc2e8c Compare October 30, 2023 15:31
@peterdeme peterdeme force-pushed the add-markdown branch 2 times, most recently from a3c6c03 to 423acc9 Compare November 20, 2023 11:53
@peterdeme peterdeme marked this pull request as ready for review November 20, 2023 11:53
adamconnelly
adamconnelly reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one question.

.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
name: 👷 ${{ matrix.cloud }}
strategy:
matrix:
cloud: [aws, aws_minimal, azure, gcp]
cloud: [aws, azure, gcp]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely meaning to remove the aws_minimal item?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @b4k3r accidentally forgot it in this pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I completely forgot about it. Thanks @peterdeme .

@peterdeme peterdeme changed the title Print markdown at the end of AWS job Print markdown at the end of the jobs Nov 20, 2023
@peterdeme peterdeme merged commit f277e1e into main Nov 20, 2023
@peterdeme peterdeme deleted the add-markdown branch November 20, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4k3r b4k3r b4k3r left review comments

@adamconnelly adamconnelly adamconnelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterdeme @b4k3r @adamconnelly