Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload commercial AWS not GovCloud #45

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Upload commercial AWS not GovCloud #45

merged 1 commit into from
Oct 25, 2023

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Oct 25, 2023

Description of the change

By accident we upload the GovCloud artifacts instead of commercial AWS.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme requested a review from TheMacies October 25, 2023 12:34
@peterdeme peterdeme merged commit 3b51385 into main Oct 25, 2023
3 checks passed
@peterdeme peterdeme deleted the fix-build-upload branch October 25, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants