Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add australia east to list of Azure replication regions #70

Conversation

daniel-edwards-nz
Copy link

Description of the change

Added the australiaeast region to the list of Azure regions that the image is replicated to. This is needed by us as we don't provision infrastructure in any of the Azure regions that are currently configured for replication therefore we are unable to use the image without this change.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@daniel-edwards-nz daniel-edwards-nz requested a review from a team as a code owner October 30, 2024 03:00
@peterdeme peterdeme mentioned this pull request Oct 30, 2024
11 tasks
@peterdeme
Copy link
Collaborator

@daniel-edwards-nz as the GitHub action jobs contain secrets, they won't run because you are an outside contributor.
Opened #71 to merge your change.

🙏 Thanks for the contribution, I'll get this out ASAP!

@peterdeme peterdeme closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants