Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable_well_known_secret_masking Has no default and breaks existing stacks with no warning of this change in the release notes #558

Closed
crouth-redge opened this issue May 23, 2024 · 2 comments

Comments

@crouth-redge
Copy link

crouth-redge commented May 23, 2024

The new enable_well_known_secret_masking option merged in #553 was not given a default value for the bool, breaking all existing stack pipelines without warning when updating to the latest release.

This should have a default to ensure backwards compatibility, or be explicitly declared as a breaking change.

 Error: could not query for stack: Cannot query field "enableWellKnownSecretMasking" on type "Stack".
 
   with spacelift_stack.rcon_i1_ecs,
   on env_i1_aws_stacks.tf line 265, in resource "spacelift_stack" "rcon_i1_ecs":
  265: resource "spacelift_stack" "rcon_i1_ecs" {
 
@crouth-redge
Copy link
Author

Actually this is something else - setting the bool does not work around it, and dropping down to 1.13.0 from 1.13.1 resulted in:

╷
│ Error: could not query for stack dependency reference: Cannot query field "triggerAlways" on type "StackDependencyReference".
│ 
│   with spacelift_stack_dependency_reference.rcon_i1_dns_d1_dns,
│   on env_i1_aws_stacks.tf line 165, in resource "spacelift_stack_dependency_reference" "rcon_i1_dns_d1_dns":
│  165: resource "spacelift_stack_dependency_reference" "rcon_i1_dns_d1_dns" {
│ 
╵

I had to drop back to 1.12.0 to get anything working in our on prem instance.

@ilya-hontarau
Copy link
Contributor

@crouth-redge Thank you for reporting this issue.

If you're using a self-hosted version, there might be a situation where the Terraform client is ahead of the self-hosted version. Please refer to this compatibility matrix to ensure you use the supported version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants