adds 'update PR comment' routes to allowlist #82
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
As part of CU-8694k6wnq (Allow notification policy to update PR comment in-place) new endpoints were added for the VCSs, in order to update the PR comments.
This change was meant to add support for Bitbucket Data Center, but because it was not known at that time that the new VCS routes must be added to the allowlist, it also add the missing routes for the Azure DevOps and Gitlab. Github enterprise doesn't need to be updated as it uses GraphQL and the main route is already added to the allowlist.
The allowlist NoMatch error message was changed in order to be clearer and avoid being confused with the gock package errors when testing (when trying to mock a HTTP request in tests, if the request URL was not in the allowlist, the test use to failed with "no match for request" which was easily confused to "the request was not properly mocked")
Type of change
Checklists
Development
Code review
Deployment