Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lose words when dragging to an occupied slot #61

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

brusherru
Copy link
Member

It fixes #39

@brusherru brusherru self-assigned this Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

You can preview the changes at : https://927430d4.smapp-lite-prod.pages.dev

@dioexul
Copy link

dioexul commented Aug 4, 2024

The bug itself is fixed (so words don't disappear). There is a strange behaviour for UI - I cannot find correlation "why" - some insert in two ways - fill the whole border and inserting as an object (like "disagree" and "phrase").
Screenshot 2024-08-04 at 11 02 50
Screenshot 2024-08-04 at 10 57 29

Copy link
Collaborator

@monikasmolarek monikasmolarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to reproduce Yulia's issues with the visual changes after dragging the words

@brusherru
Copy link
Member Author

Hm... I will check it out later. But since it's anyway better than it were before — I'm merging :)

@brusherru brusherru merged commit 3ea4014 into main Aug 6, 2024
1 check passed
@brusherru brusherru deleted the fix-39-mnemonic-verification branch August 6, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: mnemonics verification step
3 participants